Beginner question: This code seems to work. Have I missed anything?

Thanks, J.D.!