Code Review Friday: (Let's Improve your code, ask Corvid Master)

Ask the community
, ,
1

August 7th, 2020
Join this week code review organized by Corvid master,
Comment your code below(as per instruction) we will analyze provide you suggestion or refactored code that will be easy to read, to modify, and plenty of good practice.

We also welcome experience corvid forum members to share knowledge and expertise.

Instructions:

*1: FULL PAGE CODE is recommended
*2: Include database structure like Collection name & Field type (if you refer them in the code)
3: Is this a live site? If so, drop a link so, we can check the code.
4: Videos or Images for an explanation of what the code does is useful!
Marked * are required

Don’ts

1: Do NOT include any sensitive code (like passwords, secret key).

// try to rewrite it as xxx if it's used inside the code
const key = "XXX-XXX";

2: Asking any questions unrelated to code review or corvid
3: Screenshot the code and not pasting the code in text format
4: Code that was not working before and asking to fix (Please create a new post in the community, This Post is dedicated to improve your current working code)

Comment not related to refactoring for the code will be get deleted to organize

Notes

  • We do code review every Friday PST timezone!

  • This post will be locked after 24 hours

2

Hi,
I am trying to send an email notification to me when a user submits a form. I tried it the same way as sending it to the user, but that didn’t work:

wixUsers.emailUser("email",testemail@gmail.com, {
                variables: {
 "photo": $w("#textBox1").value,
                }
            })

Ok, so It works for sending the email to the user who submitted the form, but not for sending a notification email to me. Could you help me improve my code???:grin:

note: testemail@gmail.com isn’t my real email address.

3

I think you can’t send email to owner
It’s a known bug

Here is the refactor
make a variable name so others coder/ (you from future) can understand what’s going on
and you can change it easily without needing to go through all the code

const templateID = "email";
const toSend = "testemail@gmail.com";
const variables = {
  "photo": $w("#textBox1").value,
}
wixUsers.emailUser(templateID, toSend, {variables})